search

sipa / bitcoin

Bitcoin integration/staging tree
http://www.bitcoin.org
MIT License
88 stars 21 forks source link

[tests] Rename is_positive to has_square_y #119

Closed jnewbery closed 4 years ago

jnewbery commented 4 years ago

This is the terminology used in BIP 340.

Also add a comment to the function to explain what it's doing and how.

sipa commented 4 years ago

Addressed this by rewriting the code (it's now an EllipticCurve method rather than an ECPubKey one). I've used most of the comments you added here.

jnewbery commented 4 years ago

New code looks good. Thanks! :pray: