Cache hashes - Githubissues

NicolasDorier commented 8 years ago

Some notes about the implementation:

It calculates the three midstate hashes as soon as a CheckSig segwit operation happens, whathever the SigHash,
It is possible that two different threads calculate the midstate hashes of a transaction twice,

Befinits are:

hashcashes map access is limited so we don't have too much lock contention
Fewer conditional branches in consensus code
Simple to review

This commit is only for having a cache that is simple to review and understand. It is probably possible to fix the two first points above, but the code overhead is not worth it when our goal is only to fix the O(n²) issue.

instagibbs commented 8 years ago

What's the primary differences between this pull and #63?

NicolasDorier commented 8 years ago

The only difference should be that I removed the tests fixes which were cherry picked from https://github.com/sipa/bitcoin/pull/68

NicolasDorier commented 8 years ago

added some comments, and check if the scriptPubKey is actually segwit before consulting the cache (https://github.com/sipa/bitcoin/pull/70/files#diff-7ec3c68a81efff79b6ca22ac1f1eabbaR1818)

NicolasDorier commented 8 years ago

rebased, added description to the PR.

NicolasDorier commented 8 years ago

closing for rebased version https://github.com/sipa/bitcoin/pull/101

sipa / bitcoin

Cache hashes #70