Previously we used the CInv which would be sent to the peer
announcing the transaction, but now that transactions can be requested
in two ways (with or without witness) this could result in duplicate
getdata requests for the same transaction (if announced by an upgraded and
non-upgraded peer).
This appears to fix the test error I stumbled across.
sipa
commented
8 years ago
Previously we used the
CInvwhich would be sent to the peer announcing the transaction, but now that transactions can be requested in two ways (with or without witness) this could result in duplicate getdata requests for the same transaction (if announced by an upgraded and non-upgraded peer).This appears to fix the test error I stumbled across.