sipa / miniscript

Miniscript site and implementation
159 stars 47 forks source link

Modernize code: use std::optional instead of bool/outarg #114

Closed sipa closed 2 years ago

sipa commented 2 years ago

Built on top of #106.

sipa commented 2 years ago

Rebased, and addressed comments.

I've also made a few additional changes; turning inline "&& (num = ParseScriptNum(...)) &&" conditions into separate lines.

darosior commented 2 years ago

ACK 033238fd9b8126bce29446eaf018af2bdbc8c906

Checked the diff with my Bitcoin Core branch that i tested quite a lot. I didn't look for more potentially missed called sites too hard.