search

sipa / miniscript

Miniscript site and implementation
157 stars 47 forks source link

Update from the Bitcoin Core PR #99

Closed darosior closed 2 years ago

darosior commented 2 years ago

Based on #90. There are a few invasive refactorings. The rename from NodeType to Fragment can be more easily reviewed with --word-diff.

darosior commented 2 years ago

Oh i forgot to remove it. It's added in the second PR in order to have better reporting for Miniscript descriptor parsing error. -------- Original Message -------- On Feb 18, 2022, 17:56, Pieter Wuille wrote:

@sipa commented on this pull request.

In bitcoin/script/miniscript.h:

@@ -937,6 +974,22 @@ struct Node { //! Return the expression type. Type GetType() const { return typ; }

  • //! Find the deepest insane sub. Null if there is none.
  • NodeRef FindInsaneSub() const {

What is this for?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

sipa commented 2 years ago

ACK 55f2edecb57e6e166996ffcf1d480481bd1103ca. I have a few nits, but I'll open a PR to address those afterwards.