sipa / minisketch

Minisketch: an optimized library for BCH-based set reconciliation
MIT License
310 stars 52 forks source link

Add support for 0 capacity sketches #40

Closed sipa closed 3 years ago

sipa commented 3 years ago

Make minisketch_create return a functioning minisketch* when capacity=0 is passed, to remove the need for dealing with this edge case from the user.

See https://github.com/bitcoin/bitcoin/pull/21859#issuecomment-835937493 for discussion.

gmaxwell commented 3 years ago

utACK 5487f1ffa7d07298b5138e0cef74db23b183e57f

practicalswift commented 3 years ago

Post merge cr ACK 5487f1ffa7d07298b5138e0cef74db23b183e57f

Thanks for removing this edge case!