sipb / hydrant

MIT semester course planning app
https://hydrant.mit.edu/
MIT License
27 stars 18 forks source link

Add button to join class group chats on Matrix #45

Closed gabrc52 closed 1 year ago

gabrc52 commented 1 year ago

Credit: @NumberC (fadif) and @gabrc52 (rgabriel)

Screenshot:

image

This is still a draft PR (pending the questions below, and making live the web app it would redirect to), but I am creating it now to start the conversation.

Blockers:

Questions:

cjquines commented 1 year ago

Does Chakra UI offer a way to make a link (<a target="_blank" ...>) that looks exactly like a button?

wrap a button with a link tag?

gabrc52 commented 1 year ago

wrap a button with a link tag?

I wrapped it in a <a> tag and turned the link as a single expression as suggested.

cjquines commented 1 year ago

oh, if only there was a student group in mit that thinks about ui/ux

gabrc52 commented 1 year ago

Thank you!

Two options are to put the button below the activity chips or above:

image

image

I think I'd be inclined to put it above, so that the search and class list are next to each other, but I am not really sure.

The "join group chats" button is associated with the specific class selection and schedule, so it should be somewhat near the list of classes and the schedule. But so are the Google Calendar and ics options.

I agree with the latter comment. I just found out Hydrant has a preferences button. I could experiment with moving the other buttons.

gabrc52 commented 1 year ago

Thoughts about these UI changes?

Dark:

image

Light:

image

Changes (they are in another branch: https://github.com/gabrc52/hydrant/tree/matrix-and-more-ui-changes):

psvenk commented 1 year ago

Ooh, this is nice! I wholeheartedly approve of your redesign and agree with your comments.

gabrc52 commented 1 year ago

image

I've merged the UI changes and added a tooltip