search

sipcapture / hepipe.js

Pipe arbitrary data rows (logs, events, cdrs, esl, etc) to HEP Server (HOMER)
http://sipcapture.org
MIT License
25 stars 17 forks source link

include media port and ip in cache and lookup for RTCP messages #20

Closed noahmehl closed 6 years ago

noahmehl commented 6 years ago

We're using the variables from CHANNEL_ANSWER to feed back into the RTCP message.

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

noahmehl commented 6 years ago

Sorry, this isn't quite right yet.

noahmehl commented 6 years ago

Ok, we think we've got it, or are at least ALOT closer...

noahmehl commented 6 years ago

We've both signed the CLA, not sure what else we should do.

lmangani commented 6 years ago

@noahmehl this usually happens when the email or the git users don't match. In parallel we'll review the changes and merge it tomorrow. Thanks for the PR guys!

noahmehl commented 6 years ago

@lmangani Any update on this? Do you need us to do anything else with the CLA?

lmangani commented 6 years ago

If you open this link does it confirm you already signed the CLA?

noahmehl commented 6 years ago

I have signed the CLA @bgardner87 cannot, it puts him in an infinite loop :(

lmangani commented 6 years ago

Taking the risk - please confirm it all works.

noahmehl commented 6 years ago

It definitely works for us, we've been running it in production since April.

lmangani commented 6 years ago

@noahmehl thanks again for your contribution! I'll try to make sure its ported into pastash, too.