search

sipcapture / heplify-server

HEP Capture Server for HOMER
https://sipcapture.org
GNU Affero General Public License v3.0
184 stars 85 forks source link

sample reset #445

Closed abergasov closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Alexander Bergasov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

lmangani commented 3 years ago

Thanks @abergasov for your contribution! Could you kindly expand and describe what the PR does add or address?

negbie commented 3 years ago

Seems to me that he did not want to push upstream. Besides that almost every single line of that code is against Prometheus best practice in terms of cardinality.