PromTarget removes node_id tags in Prometheus metrics

[agrigorjevs]

Hello,

For some reason, when adding at least one promtarget in the config, HEP ID node_id tag disappears from metrics exported to prometheus.

Before adding PromTargets in config:

After adding at least one PromTarget (nevermind the "unknown"):

Is this intended?

[adubovikov]

Are you talking about PromTargetName ? Can you show your toml ?

[agrigorjevs]

Yeah, so I say if we add PromTargetName and PromTargetIP, node_id disappears from metrics exported.

We use heplify-server in docker environment, so we are passing env. variables like this:

HEPLIFYSERVER_PROMTARGETIP: "193.138.189.220,173.245.32.6"
HEPLIFYSERVER_PROMTARGETNAME: "csc_telecom,airespring"

[adubovikov]

can you check in the log if you have something like this:

logp.Info("successfully reloaded PromTargetIP: %#v", fsTargetIP) logp.Info("successfully reloaded PromTargetName: %#v", fsTargetName)

or just make a grep "PromTarget" and paste the result here

[adubovikov]

and grep "prometheus tag assignment"

[agrigorjevs]

@adubovikov you didn't get the issue I'm facing - the target_name labels work fine. e.g. from our dev environment: 2021/08/26 14:22:26.495858 prometheus.go:44: INFO prometheus tag assignment 1: 172.27.88.125 -> kamailio - and it metrics I see target_names

The problem is that the node_id label is not present in the metrics, if PromTargetIP and PromTargetName is set. Just check both screens above and below. Below is without PromTargetIP and PromTargetName set.

My expected behaviour is that after setting PromTargetIp and PromTargetName, node_id label should still be there.

[adubovikov]

https://github.com/sipcapture/heplify-server/pull/480

[agrigorjevs]

Hi,

@adubovikov it seems that after 1.56 version release, the "heplify-server" docker image was not updated in Docker Hub, although it says it was updated, but in reality the pulled image still comes with heplify-server 1.55.

[lmangani]

@agrigorjevs checking this - to be certain, you are referring to the latest tag correct?

[agrigorjevs]

@lmangani yup, that's correct, latest tag.

[lmangani]

@agrigorjevs seems a cache issue - rebuilt and pushed, could you pull again and check if the new image is correct?

[agrigorjevs]

@lmangani @adubovikov the image is correct now, and the issue is resolved! Thank you big for such fast help! Much appreciated.

[adubovikov]

super. You know that you have to do here: https://github.com/sipcapture/homer/stargazers

:-)