search

sipcapture / heplify

Portable and Lightweight HEP Capture Agent for HOMER
https://sipcapture.org
GNU Affero General Public License v3.0
185 stars 66 forks source link

#226 Update to allow for use of rtcp-mux where RTP is multiplexed with RTCP #227

Open hamptonng opened 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: kYroL01
:white_check_mark: lmangani
:x: Neil Hampton

Neil Hampton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

hamptonng commented 2 years ago

Not sure why, but sometimes when I run this after this change I get the following error after an RTCP message is detected:

2022/04/08 14:30:26.608643 hep.go:92: ERR write udp 10.202.118.101:42832->10.202.64.185:9060: write: message too long

This doesn't happen on every run of heplify, but when it happens it is for every RTCP message and doesn't stop until I restart heplify.

adubovikov commented 2 years ago

@kYroL01 can we merge ?

kYroL01 commented 2 years ago

@adubovikov not yet because I spotted a little bug and I need to test better. The PR is correct for that case but for default not, so I'm reverting a change that I think create the problem, do another full test and then we can merge