Closed nzspearo closed 2 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: kYroL01
:x: Matt Cornish
Hi @nzspearo Could you please refresh your PR in order to be in sync with master
? Thanks
Hi @nzspearo Could you please refresh your PR in order to be in sync with
master
? Thanks
I think this is done now. I've got that CLA issue, I've singed it but it does not seem to be linked to my commits, not sure why.
Hi @nzspearo Could you please refresh your PR in order to be in sync with
master
? ThanksI think this is done now. I've got that CLA issue, I've singed it but it does not seem to be linked to my commits, not sure why.
Thanks & sorry about this issue. You're probably using a different git identity or email when signing up the CLA?
CI still failing as follows:
Error: sniffer/sniffer.go:278:12: cfgMain.HepCollector undefined (type config.Config has no field or method HepCollector) Error: sniffer/sniffer.go:279:37: cfgMain.HepCollector undefined (type config.Config has no field or method HepCollector) Error: sniffer/sniffer.go:281:35: cfgMain.CollectOnlySip undefined (type *config.Config has no field or method CollectOnlySip) Error: Process completed with exit code 2.
@nzspearo your PR was failing because not sync with latest commit in master. I fixed it. Please try again to sign Contributor License Agreement and we're happy to merge it
Already implemented here https://github.com/sipcapture/heplify/pull/221 Thanks anyway
Adds a new flag to support discarding SIP packets by destination IP(s)
Same logic as already implemented src IP, just adds it for dst IP(s) also