sipcapture / heplify

Portable and Lightweight HEP Capture Agent for HOMER
https://sipcapture.org
GNU Affero General Public License v3.0
181 stars 65 forks source link

Correlation_id overwrite #244

Closed kosza closed 1 year ago

kosza commented 1 year ago

Hi,

I have problem with correlation between cid and rtcp. When sip server change the cid in the leg B and the rtp goes direct between the endpoints then the rtcp from B will belong to cid of leg A, the rtcp from A will belong to cid of leg B. This is because the rtcpip and rtcpport is the key in the cidCache: the cid will be overwritten with cid of last sdp with same rtcpip and rtcpport (independent from srcip of message). The next flow shows sipgnaling and rtcp, pay attention to the colors.

image

I think it would be a working solution that there would be a blacklist of srcip's, which can't overwrite existing entry in cidCache. In case of direct media usage the rtcp's belong to leg A, not shared.

lmangani commented 1 year ago

Sounds like the Agents should take this task, and/or you could write a custom mapping script to handle this type of scenario.

kosza commented 1 year ago

It sounds good. Where can I run the script? (heplify-server, homer)

lmangani commented 1 year ago

It's up to you. You might be able to adapt something using the following generics: