sipcapture / heplify

Portable and Lightweight HEP Capture Agent for HOMER
https://sipcapture.org
GNU Affero General Public License v3.0
185 stars 66 forks source link

fix: tcpassembly does not use correct timestamps #277

Closed xhantu closed 8 months ago

xhantu commented 8 months ago

tcpassembly only read the bytes of the reassembled stream and ignored other reassembly information, like seen timestamp. Therefore When assembling a HEP packet it had to use the current time. Because of parallel handling of packet capture, reassembly, and extraction this timestamp could be totally wrong.

The changed code processes the reassembly information directly and uses the timestamp of the part with the begin of the SIP message.

refs: https://github.com/sipcapture/heplify/issues/223

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xhantu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

lmangani commented 8 months ago

GREAT contribution! Thanks @xhantu 🎉

xhantu commented 8 months ago

I did not set an email when committing. How do I sign the CLA now that I can not add the email to my account?

lmangani commented 8 months ago

Error: decoder/tcpassembly.go:12:2: "github.com/negbie/logp" imported and not used