homer_mysql_rotate.pl: redundant parameter, line 157

sipcapture / homer-api

HOMER 5: Back-End (API) DEPRICATED - use sipcapture/homer-app

http://sipcapture.org

27 stars 67 forks source link

homer_mysql_rotate.pl: redundant parameter, line 157 #129

Closed gedia closed 8 years ago

gedia commented 8 years ago

Hello,

I've been getting warnings about a redundant parameter in this script. I'm not familiar with this code or perl, but the attached patch seems to quiet them.

fix-redundant-arg.txt

adubovikov commented 8 years ago

Thank you. Can u please do a pull request?

gedia commented 8 years ago

Done. #130

adubovikov commented 8 years ago

done. https://github.com/sipcapture/homer-api/commit/37a59fe6852785ee7bccb51729eb46e465ad9f56

you can close the issue :-)

gedia commented 8 years ago

I think my previous patch seriously broke the rotation script. I think #132 is the proper solution but please review this more closely. In any case, I strongly believe #130 should be reverted.

gedia commented 8 years ago

Reportedly fixed with #132