QoS tab data needs ordering

[systemcrash]

I recommend a sort at the DB (so API works cleanly), or sort on the returned JSON.

Is there a way to prevent stuff like this?:

In our testing, we see this occasionally.

[systemcrash]

This seems to be fine now. Will re-open if necessary.

[systemcrash]

This fix appears to be broken in current master. When I view the QoS tab for any call, all data types appear to be sorted in reverse order (and not forward, as expected).

e.g. for packets:

The returned JSON data from the qos endpoint shows packet and octet count correctly increasing for consecutive entries. So this is exclusively a sort problem somewhere.

[systemcrash]

Time tags are listed in chronological order. Corresponding values are displayed in reverse.

[adubovikov]

@AlexeyOplachko can you please recheck ?

[systemcrash]

Isn't it trivial to verify this bug in current master?

[adubovikov]

@systemcrash it's not complex, but we are also busy with another tasks, don't worry this one is next

[adubovikov]

@AlexeyOplachko fixed it in the last devel branch (homer-ui). Please take it and retest

[systemcrash]

Nope - still showing backwards in master. This will land tomorrow in homer-app?

How would I test with the homer-ui devel branch, should I want/need to? ( I docker-compose everything, so it uses images ).

[adubovikov]

1. git clone -b devel http://github.com/sipcapture/homer-ui
2. cd homer-ui
3. npm install
4. npm run build
5. cp dist to your homer-app directory

test it

On Mon, 19 Oct 2020 at 19:26, Paul Dee notifications@github.com wrote:

Nope - still showing backwards in master. This will land tomorrow in homer-app?

How would I test with the homer-ui devel branch, should I want/need to?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sipcapture/homer-app/issues/345#issuecomment-712315300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCN2JPLRWUIPUJYXZQ3ERDSLRZGDANCNFSM4NAZ765A .

[adubovikov]

sorry, but I have cleary wrote - devel branch. Not master

[systemcrash]

1. git clone -b devel http://github.com/sipcapture/homer-ui 2. cd homer-ui 3. npm install 4. npm run build 5. cp dist to your homer-app directory test it

Ok - thank you. This would be good in the wiki. But since I docker-compose, and only have images.....

[adubovikov]

in this case you have to wait until our dev-team will not finish all tests and only after push everything to the master.

On Mon, 19 Oct 2020 at 20:02, Paul Dee notifications@github.com wrote:

1. git clone -b devel http://github.com/sipcapture/homer-ui https://github.com/sipcapture/homer-ui 2. cd homer-ui 3. npm install
2. npm run build 5. cp dist to your homer-app directory test it

Ok - thank you. This would be good in the wiki. But since I docker-compose, and only have images.....

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sipcapture/homer-app/issues/345#issuecomment-712344642, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCN2JKQ33JXU3OQ5MYCSG3SLR5KNANCNFSM4NAZ765A .

[systemcrash]

Pulled current master. Appears as though this commit has fixed sort order, once again.

https://github.com/sipcapture/homer-ui/commit/b1f77fa53c4a720ea3e0a48ad036153c492566d3

[adubovikov]

you are welcome. Don't forget to star our project: https://github.com/sipcapture/homer/stargazers

[adubovikov]

thank you, but better to star homer project - this is out front page :-)

[systemcrash]

Stalker 😉