sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
207 stars 85 forks source link

Fix trailing comma which prevents Homer from starting up. #347

Closed systemcrash closed 4 years ago

systemcrash commented 4 years ago

Produces the rather confusing and counter-intuitive error message

No configuration file loaded: While parsing config: invalid character '}' looking for beginning of object key string

panic: DB configuration file not found

etc

lmangani commented 4 years ago

Thanks for the fix! This is actually correct on behalf of the JSON parser, } is an invalid character after , so the error message seems accurate, perhaps we need a generic one telling the user the JSON configuration is invalid.

systemcrash commented 4 years ago

the question was which } was invalid ;) my highlighter didn't pick up on the floating comma....

systemcrash commented 4 years ago

Should this have triggered a rebuild? The webapp/homer image currently won't start otherwise. Maybe weekends are time off for the builds :)