sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
204 stars 79 forks source link

Filter dup packets in call flow #426

Closed dmsf100 closed 3 years ago

dmsf100 commented 3 years ago

We've been using homer and noted that when we have several network nodes reporting to a heplify-server cluster some dup packets are created with different Capture IDs. This code filters the dups only in the call flow. We've been using this for a while with no issues.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

adubovikov commented 3 years ago

thank you so much for your contribution! Can you please make it as a configurable param ? system_settings.deduplicate = true/false ?

dmsf100 commented 3 years ago

I'll try to make that change yes!

dmsf100 commented 3 years ago

I'm trying to pass that setting from main.go to the data/service/search.go and I'm struggling to get it all the way through. Do you have any suggestion @adubovikov?

adubovikov commented 3 years ago

I will do :-) lets merge it and the rest goes to my shoulders :-)

adubovikov commented 3 years ago

thank you!

adubovikov commented 3 years ago

Here you are: https://github.com/sipcapture/homer-app/commit/11032c3263f4170b5dcaf873c1b8cced7ccc7270

"transaction_settings": {    
         "deduplicate": {        
                "global": true    
         }  
},
rnalrd commented 4 months ago

@dmsf100 "heplify-server cluster" caught my attention. I'm looking at options to load balance HEP traffic ingested by heplify-server. As I understand each heplify sever needs exclusive access to the PGSQL DB, is that right? Or disabling "DBRotate" would allow two heplify-servers to write into the same DB?