sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
204 stars 79 forks source link

Capture ID issue #437

Closed mcrgnt closed 3 years ago

mcrgnt commented 3 years ago

Hello. (dist from homer-app repository v1.4.2)

capture agent starts with flags: ./heplify -hs 192.168.10.4:9060 -nt udp -hi 1001 -hn sip3 -n log in this case i got human readable Capture ID in ui,

but when i try to search by Capture ID i get postgres error: homer_user@homer_data ERROR: invalid input syntax for integer: "sip3"

According to heplify help options: -hi uint HEP node ID (default 2002) -hn string HEP node Name

Then i was try: ./heplify -hs 192.168.10.4:9060 -nt udp -hi 2001 -hn 2001 -n log in this case i got integer Capture ID in ui which is not so usable

I have a question, how hn option should work? Does "HEP node Name" mean capture agent name? Anyway, we have some inconsistent data with input type and ui type.

lmangani commented 3 years ago

@mcrgnt should use integer identifiers with hi (capture_id). hn will only work with hepfliy/heplify-server but it is experimental and hence not documented for usage or supported uniformly as of yet. If you have inconsistencies please open separate issues.

adubovikov commented 3 years ago

where do you see that issue? Is it error in homer-app?

On Sun, 12 Sep 2021, 17:33 Lorenzo Mangani @.***> wrote:

@mcrgnt https://github.com/mcrgnt should use integer identifiers with hi (capture_id). hn will only work with hepfliy/heplify-server but it is experimental and hence not documented for usage or supported uniformly as of yet. If you have inconsistencies please open separate issues.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sipcapture/homer-app/issues/437#issuecomment-917658191, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCN2JLZMLIBJRF6PGLIRHDUBTB33ANCNFSM5D4EDFRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mcrgnt commented 3 years ago

thx for reply,

"Is it error in homer-app?" yes, i think so, because setting -hn flag overrides -hi (and types mismatch)

i use hepfliy/heplify-server/homer-app/homer-ui bunch. i try like lmangani advised use only -hi flag, of course it's works.

p.s. i understand that is easy just close issue, but use names is better then int ids for humans may be just add full support for node name in homer-ui? i mean add capture_name in search fields list and don't override hi flag if hn is set. or add support node names with aliases, aka hash name->ip, cause now setting captureid in alias actually do nothing (may be add alias search field?)

again thx for reply

adubovikov commented 3 years ago

thx for reply,

"Is it error in homer-app?" yes, i think so, because setting -hn flag overrides -hi (and types mismatch)

i use hepfliy/heplify-server/homer-app/homer-ui bunch. i try like lmangani advised use only -hi flag, of course it's works.

p.s. i understand that is easy just close issue, but use names is better then int ids for humans may be just add full support for node name in homer-ui? i mean add capture_name in search fields list and don't override hi flag if hn is set. or add support node names with aliases, aka hash name->ip, cause now setting captureid in alias actually do nothing (may be add alias search field?)

again thx for reply

@lmangani closed it because this is not an issue, since the feature is/was experimental and not fully supported in the homer-app/UI. So this was total correct. But just to make all happy, it should be open as a feature request in UI/homer-app :-)

adubovikov commented 3 years ago

so, just checked - good news here

System ->Mapping -> call SIP click edit. Find the capture ID and change it. After it go to widget and reassign the field :-)

HOMER-7-10-2 (1)

once you will figure it out, don't forget to star us :-)

https://github.com/sipcapture/homer/stargazers

adubovikov commented 3 years ago

@mcrgnt Did it help ?

microgiantya commented 3 years ago

yes it works!

adubovikov commented 3 years ago

@microgiantya so, now is your turn: please give us a star https://github.com/sipcapture/homer/stargazers

mcrgnt commented 3 years ago

Сделано))

adubovikov commented 3 years ago

two accounts ? :-) two stars ? ;-) Thank you!