search

sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
204 stars 79 forks source link

OR logic - timestamp included in search #459

Closed ghmj2417 closed 2 years ago

ghmj2417 commented 2 years ago

Is it intentional to include the timestamp part of the OR search?

For example, I set orlogic: true, and add params dstIP and srcPort for the search. I set the timestamp for the past 24 hours. I am seeing the results for the dstIP and srcPort, but I am also seeing all of the records for the past 24 hours. I didn't expect this behavior. I think most of us would only want the results for the search params of dstIP and srcPort.

github-actions[bot] commented 2 years ago

Your report is appreciated. Please star this repository to motivate its developers! :star:

lmangani commented 2 years ago

Sounds like a potential bug indeed - investigating

adubovikov commented 2 years ago

https://github.com/sipcapture/homer-app/commit/f2cdde3b471d6e5422621655ca2e6a02dd2aaf62

adubovikov commented 2 years ago

@RFbkak37y3kIY the bug with AND/OR still valid - switcher doesn't reset the value and it always sends "true"

ghmj2417 commented 2 years ago

Thank you for the app fix @adubovikov!

Are you referring to the UI issue that I created? https://github.com/sipcapture/homer-ui/issues/562

adubovikov commented 2 years ago

@ghmj2417 ah, yes, you did it! In this case I will close the ticket. please star us here: https://github.com/sipcapture/homer/stargazers