sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
204 stars 79 forks source link

Docker LDAP variables override #468

Closed wurwik closed 2 years ago

wurwik commented 2 years ago

Added homer docker additional LDAP variables override, and added additional LDAP settings into webapp_config.json docker version.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

lmangani commented 2 years ago

Thanks for your contribution @wurwik could you kindly sign the CLA to trigger the automated build process?

wurwik commented 2 years ago

Approved CLA

agrigorjevs commented 2 years ago

@lmangani it seems that the latest docker hub image build was built with cache and the new changes are not present in the docker image.

lmangani commented 2 years ago

The builder should be using no-cache by default, have you tried a local build to confirm?

wurwik commented 2 years ago

On my local machine build fails when running "make docker". I also have tried to run separately "make build" and "make frontend", and fails with the same error on step "make frontend". Here the output of "make docker"output.txt

agrigorjevs commented 2 years ago

@lmangani running docker run --rm sipcapture/webapp cat docker-entrypoint.d/1 does not reveal that the changes in this PR are present in the latest Docker Hub image.

lmangani commented 2 years ago

I think I see where the problem is, let me unblock the CI pipeline and confirm back.

wurwik commented 2 years ago

The latest build on the docker hub contains the latest changes! Thank You!