Open Anthony-Bible opened 1 year ago
Your report is appreciated. Please star this repository to motivate its developers! :star:
Your report is appreciated. Please star this repository to motivate its developers! :star:
please check how the viper supports ENV github.com/spf13/viper
@adubovikov thanks, But homer-app currently doesn't use viper to get environment variables only to read the config as far as I can tell . I was referring to this: https://github.com/sipcapture/homer-app/blob/master/docker/docker-entrypoint.d/1
I know and I wrote this comment because you mentioned PR :-) otherwise we will redesign the part of viper reader to use it in more intelligent way.
On Thu, Oct 27, 2022, 1:02 AM Anthony Bible @.***> wrote:
@adubovikov https://github.com/adubovikov thanks, But homer-app currently doesn't use viper to get environment variables only to read the config as far as I can tell . I was referring to this: https://github.com/sipcapture/homer-app/blob/master/docker/docker-entrypoint.d/1
— Reply to this email directly, view it on GitHub https://github.com/sipcapture/homer-app/issues/496#issuecomment-1292756391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCN2JO2344FI7T42QD2GTTWFG2BFANCNFSM6AAAAAARPJIRBQ . You are receiving this because you were mentioned.Message ID: @.***>
We have started working on it.
It would be nice to allow the http debug to be set by an environment variable at startup. Is there a reason it isn't? If not I'd be more than willing to create a PR to allow that.