sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
207 stars 85 forks source link

relase tagging #546

Closed systemcrash closed 2 months ago

systemcrash commented 9 months ago

I know release tagging isn't everyone's favourite thing to do, but the 1.4.59 release tagged in November has assets fresh from a few days ago... confusing:

Screenshot 2024-02-22 at 16 59 20

Is this intended? That the latest versions inherits all the latest changes until... the next successive version?

Your GH action for PR #545 logs this:

Run boxpositron/upload-multiple-releases@1.0.7
Found 4 asset(s)
homer-app
homer-app-1.4.59-amd64.deb
homer-app-1.4.59-amd64.rpm
homer-ui-1.4.59.tgz
Resolving tag
Release exists, overwriting assets.
Overwriting homer-app
Uploaded homer-app
Overwriting homer-app-1.4.59-amd64.deb
Uploaded homer-app-1.4.59-amd64.deb
Overwriting homer-app-1.4.59-amd64.rpm
Uploaded homer-app-1.4.59-amd64.rpm
Overwriting homer-ui-1.4.59.tgz
Uploaded homer-ui-1.4.59.tgz
lmangani commented 9 months ago

That's more or less the current status indeed. The CI/Release pipeline uses this floating release as a hooking point and not as a distribution medium for our setups which are all package repository based or container based. If this is important and useful we can of course create new releases instead, but in order to do so we should move this last remaining pipeline to github actiions.

systemcrash commented 9 months ago

Just let the releaser auto-increment the version number when new features get added or PRs get merged, rather than keep adding features to the latest version release. master/latest is fine with everything new going in there. But nailing an image to a particular release version should be an option (so that e.g. checksums match).

https://github.com/sipcapture/homer-app/blob/5327f33cfff127000e4581b28bc690d8d289fcd0/.github/workflows/build.yml#L72-L80

DEFAULT_BUMP should be something like patch

https://github.com/anothrNick/github-tag-action

systemcrash commented 9 months ago

Check also the warnings for your GH actions which run, and bump some of those actions to newer versions.

adubovikov commented 2 months ago

I hope now it works as expected:

image