search

sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
207 stars 85 forks source link

fix for using 'homer_user' as ldap groupname #565

Closed bilalrao12 closed 1 month ago

bilalrao12 commented 2 months ago

There are 2 issues where "homer_user" as a LDAP usergroup name clashes with db user in entrypoint.sh as mentioned here:

https://github.com/sipcapture/homer7-docker/issues/145 https://github.com/sipcapture/homer/issues/592

This PR will fix the issue.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

Dletta commented 1 month ago

Please make sure to update all relevant instances. (There is 2 documentation files that need it still)

bilalrao12 commented 1 month ago

So, I rechecked this and as the issue can only happen on docker so i think we should only make changes to these 2 files and not touch the other files which are used for on host installtion.

https://github.com/sipcapture/homer-app/blob/master/Dockerfile COPY --from=webapi /homer-app/docker/webapp_config.json /usr/local/homer/etc/webapp_config.json

which is below file and only this needs to be changed. https://github.com/sipcapture/homer-app/blob/master/docker/webapp_config.json

homer_db_host is also only in these docker files. in other files its 'host'