sipcapture / homer-app

HOMER 7.x Front-End and API Server
http://sipcapture.io
GNU Affero General Public License v3.0
207 stars 85 forks source link

CI automation is overwriting the most recent release on PR merge #571

Open aukeman opened 1 month ago

aukeman commented 1 month ago

It appears that the github actions that fire on PR merges to master are building, packaging, and overwriting the most recent release based on the latest commit to the master branch. The result is that the binaries and and package files in the release are no longer based on the tagged commit indicated by the release name.

cf. the actions run upon merge of #569:

The release page for 1.5.3 shows that the release artifacts are far more recent than the tagged commit, and the release artifact checksums have been modified since last week.

I believe the issue is that the Build Packages, Archive Frontend, and Upload Release steps are being run on merges to master when perhaps it would be more appropriate for them to run only when github.even_name == 'release' ?

github-actions[bot] commented 1 month ago

Your report is appreciated. Please star this repository to motivate its developers! :star: