search

sipcapture / homer5-docker

HOMER 5 Docker Containers (OBSOLETE)
http://sipcapture.org
40 stars 61 forks source link

Pin version in Dockerfiles #11

Open dougbtv opened 8 years ago

dougbtv commented 8 years ago

I'm building a commit right now that pins the homer-api & homer-ui verisons by commit hash. This one: https://github.com/sipcapture/homer-docker/commit/e8fa985261173e56fe71f597957937bfb6dafae3

On my wishlist is tags with semver or something (which I see has been done at least during major releases, very nice) on those projects. It will look nicer in the dockerfile when I can pin it at specific tags, e.g. we can clone a tag like...

git clone --branch vX.Y.Z https://github.com/sipcapture/homer-ui.git

Because we've had homer-ui & homer-api running @ HEAD I'm running into a bit of "Schrödinger's Docker images" where I don't know if the Dockerfile is going to be working or not until I build it. In this case today, because of some changes to the new rotation scripts, I'm seeing it happen again.

For now, I'm just going to git checkout [sha-1] in the Dockerfile, and I'll merge what I've got for now (assuming the build is verified). But, this will allow us to be sure that it will work when HEAD is changing on the primary projects. And, when the time's right, to go ahead and test it out with newer commits.

lmangani commented 8 years ago

Hey Doug!

Excellent point! A solution to this is actually be possible by pulling the sipcapture/homer repository which contains the sumodules pointers - those are currently updated when we fix something, but with a little bit of method, we could leverage the main repository (and branches) to control what we serve to the stable front (containers, installers, etc) and leave direct pull from ui/api repos for the developers - Just a proposal for the bunch to comment on.

dougbtv commented 8 years ago

Ahhhh ha! You've got submodules in there. That..... that is actually quite awesome. And maybe something that I can start making use of sooner than later.

Absolutely curious to hear what everyone likes, I'd just like to leverage what you guys have in place, and what makes sense for everyone.

mbrooks commented 7 years ago

This maybe the wrong place to request this, but tagging the release version for the entire project would be nice. We're currently having to use the git commit hash as well. I can submit a PR if you guys are interesting in versioning this.

sfrique commented 6 years ago

Also it would be nice to build the images and pull it to somewhere (docker hub?). So new users don't have to build the image, only use it.