search

sipcapture / homer7-docker

HOMER 7 Docker Images
93 stars 84 forks source link

Incorrect config docker-entrypoint.d/1 for LDAP #127

Open perrfect opened 2 years ago

perrfect commented 2 years ago

For file 1 in docker-entrypoints.d I've found incorrect configuration:

  1. In the line if [ -n "$LDAP_ADMINGROUP" ]; then sed -i "/admingroup/ s/admin/${LDAP_ADMINGROUP}/g" /usr/local/homer/etc/webapp_config.json; fi if my admin group has not admin name I will get incorrect webapp_config.json For example: If my admin group has name - homer_admins_test in webapp_config.json I will get "homer_admins_testgroup": "homer_admins_test" because sed changes all words admin

  2. For if [ -n "$LDAP_GROUP_ATTRIB" ]; then sed -i "/group_attributes/ {N;N;N;N;N;N;N;N; s/\[.*/\[\n\t${LDAP_GROUP_ATTRIB}\n\t\],/g}" /usr/local/homer/etc/webapp_config.json; fi when I set LDAP_GROUP_ATTRIB, the line "admingroup": disappears in in the json - webapp_config.json.