search

sipcapture / homer7-docker

HOMER 7 Docker Images
93 stars 84 forks source link

heplify-server gets some 2024 love #153

Open systemcrash opened 5 months ago

systemcrash commented 5 months ago

This includes an accumulation of tweaks which have kept my stack going. Some necessary to run contemporary Grafana/Loki etc versions.

I pointed homer-webapp image from docker repo to GHCR.

A couple of config changes for Loki were spawned from this https://github.com/grafana/loki/issues/2018#issuecomment-970789233 so I took the liberty of enabling Loki changes (including WAL) where Loki is configured, and giving that a volume path. WAL is good to have, altho I don't think new users starting with these stack compose kits will encounter the upgrade problem I did.

Happy Easter 🐣 🥚 🌴

adubovikov commented 5 months ago

Thank you so much! Happy Eastern!

lmangani commented 5 months ago

Thanks for the contribution @systemcrash! We truly appreciate it 🥇 As you might know, we develop a drop-in compatible LGTM replacement (qryn) and HOMER 10 is based on it, so having loki as part of this or any other recipe doesn't make sense anymore. Would you be ok filtering the loki parts out of the PR so we can merge this? If that's unviable, I'll merge and proceed with replacing. Thanks once again and happy easter!

systemcrash commented 5 months ago

So, just drop the loki: changes, because loki is leaving, and force push? Sure.

Did not know.

systemcrash commented 5 months ago

I figure that if loki goes, promtail does too. So everything except for the delete can go.

lmangani commented 5 months ago

@systemcrash nothing really goes when it comes to clients - qryn is 100% loki compatible. We just don't use Grafana Loki, but everything else remains as powerful as ever.

systemcrash commented 5 months ago

@systemcrash nothing really goes when it comes to clients - qryn is 100% loki compatible. We just don't use Grafana Loki, but everything else remains as powerful as ever.

My point being that promtail is part of Loki. So if (Grafana) Loki is no longer used, then having promtail config is kind of pointless :)

lmangani commented 5 months ago

@systemcrash

My point being that promtail is part of Loki.

And qryn is 100% compatible with it. Promtail and any other Loki client continues to work.

So if (Grafana) Loki is no longer used, then having promtail config is kind of pointless :)

qryn is 100% compatible with Loki. Grafana as a client, and all LogQL queries continue working as before.

We're just swapping Loki for qryn, without any changes required to any client or integration

You can read up about qryn here: https://github.com/metrico/qryn

systemcrash commented 4 months ago

is this ready?