Kaian
commented
8 years ago Please, ignore this PR.
While the pcap (the link is broken, but I can still send it if you provide me an email) is still valid for testing the problem, this changes introduce parsing errors in other situations. If you're still willing to debug this not displayed packet (which seems related with reassembly), I could open another pull request.
Best regrads
Hi!
The linked [1] pcap capture has two ACK messages that are not being displayed by sipgrep.
It seems some packets before those ACK have some kind of padding that makes the capture length reported by libpcap doesn't match the sum of headers and payload. I'm not sure if this triggers the tcp reassembly logic, but fixing the length of this packets (or totally skipping them) shows those ACK messages. Also don't know if this padding is related with some kind of network cards because I have not created the pcap.
This PR includes a fixup for the length. If you find a better approach or determines the pcap file is not valid for some reason, feel free to discard it :)
Thanks!!
[1] https://goo.gl/xHn5gT