Migrate to embedded-hal 1.0.0-alpha5

sipeed / bl602-hal

Hardware Abstract Layer for BL602 RISC-V WiFi + BLE SoC in embedded Rust

Other

75 stars 14 forks source link

Migrate to embedded-hal 1.0.0-alpha5 #29

Closed 9names closed 3 years ago

9names commented 3 years ago

Lots of little changes to bring us over to alpha5. The biggest change is the lack of Default impls for some traits in SPI. I implemented the GPIO toggle trait manually, as I figure that's going to be commonly used.

I also renamed the i2c, rtc and spi constructors to be called new() because clippy complained and calling hal::i2c::I2c::i2c() feels pretty silly. That was the last change, and I can back it out if it is too much.

luojia65 commented 3 years ago

LGTM

bjoernQ commented 3 years ago

Looks good to me

I also tested the samples and they work fine with the exception of the SSD1306 example but that's because of the transitive dependency _embedded_graphicscore 0.3.3 (with 0.3.2 it works) - so the PR is totally fine

9names commented 3 years ago

Thanks for the reviews, going to merge this now