search

sipgate / sipgate.io

Create custom telephony integration solutions. Play audio files, manage your devices, reject the call, present dial tone menus or just create statistics. Adapt telephony to your business needs, control your home automation with your phone or just create that funny hack to make using the phone more enjoyable. @sipgate.io, https://twitter.com/sipgateio
https://www.sipgate.io
Other
200 stars 32 forks source link

Update Documentation for Voicemail redirects #106

Open pwfraley opened 7 years ago

pwfraley commented 7 years ago

We just noticed, that when someone has a redirect to voicemail after x seconds, then sipgate.io will register it as a new call with a new call id. In the newcall event, there is now a callId and a origCallId.

Unfortunately there is no mention about this in the documentation. This caused an error in our system, because every unanswered call showed up twice in our system.

danielberlin commented 7 years ago

It's mentioned here: https://github.com/sipgate/sipgate.io/commit/8c58cd839fa636e43fcc78821563173a442b21c3

BlackMac commented 7 years ago

What can we do to make the documentation more obvious?

pwfraley commented 7 years ago

Maybe it would be more obvious if the tables for the events in the README.md would list all params possible? Also I find no mention in the README.md of the originalCallId, it would be nice to also have it mentioned there (https://github.com/sipgate/sipgate.io/blob/master/README.md)

@danielberlin origCallId is not mentioned in that commit.