search

siphomateke / deezer

Unofficial script to install Deezer Desktop on Ubuntu. Based on AUR Script (https://aur.archlinux.org/packages/deezer/) by SibrenVasse
151 stars 11 forks source link

Update install.sh #3

Closed FoggyMtnDrifter closed 4 years ago

FoggyMtnDrifter commented 4 years ago

Removing these lines and instead including them in the ReadMe since so many users (including me) are having issues installing NPM packages via the sh file.

ToMattBan commented 4 years ago

For me this don't work too.

rm: cannot remove 'app': No such file or directory
rm: cannot remove '/home/user/Downloads/Deezer/deezer/npm_temp': No such file or directory
./install.sh: 26: ./install.sh: asar: not found
rm: cannot remove 'app/node_modules/@nodert': No such file or directory
./install.sh: 36: ./install.sh: npm: not found
mv: cannot stat 'node_modules/*': No such file or directory
./install.sh: 47: ./install.sh: prettier: not found
./install.sh: 48: ./install.sh: prettier: not found
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/build/main.js b/build/main.js
|index a229f52..0f1955b 100644
|--- a/build/main.js
|+++ b/build/main.js
--------------------------
File to patch:

Just stay at this. Waiting for me do something

FoggyMtnDrifter commented 4 years ago

For me this don't work too.

rm: cannot remove 'app': No such file or directory
rm: cannot remove '/home/user/Downloads/Deezer/deezer/npm_temp': No such file or directory
./install.sh: 26: ./install.sh: asar: not found
rm: cannot remove 'app/node_modules/@nodert': No such file or directory
./install.sh: 36: ./install.sh: npm: not found
mv: cannot stat 'node_modules/*': No such file or directory
./install.sh: 47: ./install.sh: prettier: not found
./install.sh: 48: ./install.sh: prettier: not found
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/build/main.js b/build/main.js
|index a229f52..0f1955b 100644
|--- a/build/main.js
|+++ b/build/main.js
--------------------------
File to patch:

Just stay at this. Waiting for me do something

Yeah, seems I made a PR too early. I'm facing the same issue.

Renaud-Pagin commented 4 years ago

I get same `./install.sh: 48: cd: can't cd to /root/deezer/resources/app [error] No files matching the pattern were found: "build/.js". [error] No files matching the pattern were found: "build/assets/cache/js/route-nabooads*.js". can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was:

|diff --git a/build/main.js b/build/main.js |index a229f52..0f1955b 100644 |--- a/build/main.js |+++ b/build/main.js

`

But when i looked on top i saw this error in my system : `2020-07-06 21:50:06 (8,57 MB/s) - ‘deezer-4.20.21-setup.exe’ saved [70179096/70179096]

./install.sh: 20: 7z: not found ./install.sh: 22: 7z: not found convert-im6.q16: unable to open image resources/win/app.ico': No such file or directory @ error/blob.c/OpenBlob/2874. convert-im6.q16: no images definedresources/win/deezer.png' @ error/convert.c/ConvertImageCommand/3258. ./install.sh: 27: cd: can't cd to resources/ fs.js:114 throw err; ^ `

As 7z is missing the script can not processing of unpacking deezer.exe !

Check if 7z cmd is installed on your system !

siphomateke commented 4 years ago

Thank you for this but I'd rather fix the issues and keep the installation process simple. I believe I've fixed most of the issues now so please test again.

@Renaud-Pagin 7z should indeed be installed and should be automatically installed by the script using this command apt install p7zip imagemagick nodejs wget. Did p7zip not install when you ran install.sh?

Renaud-Pagin commented 4 years ago

Better to close before fixing ... nice smart move !

Le lun. 6 juil. 2020 à 23:01, Sipho Mateke notifications@github.com a écrit :

Closed #3 https://github.com/siphomateke/deezer/pull/3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/siphomateke/deezer/pull/3#event-3517636763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPKV5XAUFS67IT2B53DGDDR2I3T5ANCNFSM4OR2BNUQ .

siphomateke commented 4 years ago

@Renaud-Pagin This pull request was created because there was a bug in the install script. I don't think it makes sense to accept a pull request that offers a workaround when the actual bug can be fixed. Your particular issue with p7zip was unrelated to this pull request and should have been a separate issue. Either way, it has now been fixed.