search

siphomateke / zra-helper

A browser extension that automates various aspects of the ZRA website.
Other
0 stars 1 forks source link

Get pending liabilities doesn't work on clients whose tax account names have hyphens #118

Closed siphomateke closed 5 years ago

siphomateke commented 5 years ago

Version v1.3.1 and above

Describe the bug Getting pending liabilities of clients whose tax accounts names have hyphens in them fails silently. The sub tasks to get totals say "Get undefined totals" but don't error. Additionally, no errors are indicated in the output:

"Client","ITX","","","","",""
"","VAT","","","","",""
"","PAYE","","","","",""
"","TOT","","","","",""
"","WHT","","","","",""
"","PTT","","","","",""
"","MINROY","","","","",""
"","TLEVY","","","","",""

To Reproduce Steps to reproduce the behavior:

  1. Load a client whose tax account name has a hyphen. For example, "CLIENT-NAME-PROPERTY TRANSFER TAX"
  2. Run get pending liabilities
  3. Observe that the pending liabilities are not retrieved

Expected behavior The pending liabilities for the clients should either successfully retrieve or fail with an error.