search

sippy / rtpproxy

The RTPproxy is a high-performance software proxy for RTP streams that can work together with Sippy B2BUA, Kamailio, OpenSIPS and SER.
http://rtpproxy.org
BSD 2-Clause "Simplified" License
417 stars 114 forks source link

rtpp_acct_rtcp_hep - RTCP Type 203 (BYE)? #134

Open solarmon opened 1 year ago

solarmon commented 1 year ago

Hi,

Please can you confirm whether rtpp_acct_rtcp_hep will capture and send RTCP type 203 (BYE)?

I can see that it is defined in:

https://github.com/sippy/rtpproxy/blob/b9d7b4ced2e9797f7d5d3f033af288fbc1aaecd8/modules/acct_rtcp_hep/rtcp.h https://github.com/sippy/rtpproxy/blob/ba8c96a934e1ee70b5adbf9a029531e852d682bf/modules/acct_rtcp_hep/rtcp2json.c

But it does not seem to be doing anything with it, or am I not reading the code correctly?

Thank you!

sobomax commented 1 year ago

Hi, good question! Actually your reading is not quite correct the code you see is the copy from the rtptools package: at the time we've only had the requirements/spec/samples for the SR (sender report) and RTCP_RR (receiver report) packets. I left the rest of the code which originally just prints out various fields to the stdout intact and just disabled it using #if 0 / #endif block. For future integration and in the hope that someone might fill in the blank one day.

The task is quite small (98% of work is done already), so if you have a real need to have this feature we can collaborate to make it happen. All I would need is some sample(s) of RTCP BYE packet and associated HEP Json plus some commitment to do integration testing once the code is complete.

Let me know if that is something that you are interested in doing. Thanks a lot!

-Max

solarmon commented 1 year ago

Hi @sobomax

I'm not sure whether we actually need this or not - I'm not even sure what the significance of these RTCP Goodbye packets are. I just wanted to understand what rtpproxy was capturing and sending to Homer.

We are getting rtpproxy to send these captured RTCP packets to Homer, and we were seeing that Homer doesn't seem to be showing all the RTCP packets, when comparing to a tcpdump capture. I wasn't sure whether that was because rtpproxy was not capturing and sending all the RTCP packets, or there is a display issue with RTCP in Homer.