search

sipsorcery-org / sipsorcery

A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.
https://sipsorcery-org.github.io/sipsorcery
Other
1.39k stars 424 forks source link

Adding ECDSA as certificate type Fixes #1104 #1105

Closed moorecj closed 3 months ago

moorecj commented 3 months ago

Chrome is now checking certificate type and needs to be passed the correct one in Certificate Request. WebRTC primarily uses ECDSA, I believe the intent is to support ECDSA, per TLS protocol, you need to say so in the CertificateRequest message.

Adding ECDSA to DtlsSrtpClient.cs as just to remain in sync with the server code but I have no way to verify that direction.

Fixes https://github.com/sipsorcery-org/sipsorcery/issues/1104

sipsorcery commented 3 months ago

I'll merge this and happy to make a new release once an additional person can confrim the fix works.

moorecj commented 3 months ago

I'll merge this and happy to make a new release once an additional person can confrim the fix works.

This pull request contains the reciprocal to the DtlsSrtpClient side of this as well. I am not sure if there is a easy way to test that direction, our app only uses DtlsSrtpServer. If you know of any of the examples that use it I can run a test to verify that is good as well.