search

sipsorcery-org / sipsorcery

A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.
https://sipsorcery-org.github.io/sipsorcery
Other
1.39k stars 424 forks source link

Possible Null pointer exception if using MdnsResolve #1116

Open helu-milestone opened 2 months ago

helu-milestone commented 2 months ago

In RtpIceChannel.cs line 2645 returns null in case the MdnsResolve fails to resolve the mDNS address. I think null should be changed into an Empty.Array() to avoid null pointer exception in line 1376.

I would like to make a pull request with this small fix, but I have no branch. How do I contribute to the project?

helu-milestone commented 2 months ago

For anyone else new to OpenSource you can make a fork of the repository. Create a fix in your own repository and after that github will show that you are ahead of SipSorcery repostory and you can make a pull request