search

sipsorcery-org / sipsorcery

A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.
https://sipsorcery-org.github.io/sipsorcery
Other
1.39k stars 424 forks source link

SDP parser introduces an rtcp-fb that does not exist in the content #1130

Open SteveAyre opened 1 month ago

SteveAyre commented 1 month ago

Commit 1c1ca9f2b7 introduced a a=rtcp-fb:PT goog-remb attribute when parsing SDP that does not exist in the SDP content being parsed.

This appears to be because it adds a SupportedRtcpFeedbackMessages list which is initialised with a constant value rather than being sourced from the parsed content.

This incorrectly indicates to the calling code that the other UA supports a feature that it does not.