Increase SDP AnnouncementVersion to an unsigned 64-bit integer.

sipsorcery-org / sipsorcery

A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.

https://sipsorcery-org.github.io/sipsorcery

Other

1.39k stars 424 forks source link

Increase SDP AnnouncementVersion to an unsigned 64-bit integer. #1132

Closed SteveAyre closed 2 weeks ago

SteveAyre commented 1 month ago

Using a signed 32-bit integer was ignoring large values seen in the wild such as from RTPEngine (64bit populated by SSL_random) and NTP timestamps which are 64-bit and recommended by the SDP RFC.