sipsorcery-org / sipsorcery

A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.
https://sipsorcery-org.github.io/sipsorcery
Other
1.47k stars 442 forks source link

RTP Sequence number cannot be auto generated in all cases. #996

Closed moorecj closed 9 months ago

moorecj commented 1 year ago

I have run into an issue implementing a webrtc media server where the RTP sequence number must be past along inside the media server.

A simple example of my setup is this: remote publisher --- (webrtc connection 1) ---> media server (Sipsorcery) ---(webrtc connection 2)---> remote consumer

I have found that auto generating sequence numbers causes remote consumers that are connected to the server to not be aware of packets that are dropped from the remote publishers to the media server.

As a result packets that are not actually sequential get marked as sequential and this causes distortion on the consuming client side.

I have created a pull request to try and address this issue. https://github.com/sipsorcery-org/sipsorcery/pull/995

sipsorcery commented 9 months ago

PR was merged.