search

sipsorcery / webrtc-echoes

Simple useful interoperability tests for WebRTC libraries. If you are a WebRTC library developer we'd love to include you!
173 stars 17 forks source link

Timeout for werift Echo Test Client #22

Closed sipsorcery closed 3 years ago

sipsorcery commented 3 years ago

There have been a few instances where the automated tests with the werift client have gotten stuck. I don't know the reason yet. The consequence of getting stuck is that the GitHub Action Workflow will stay running for 6 hours before being killed by the CI server.

It'd be great if a timeout could be added to the werift client so that if the echo test does not work for whatever reason it exits with a failure code of 1 (or anything but 0). The other two clients are using a 10s timeout.

Below is a screenshot of the action workflow if I change the Echo Test Server hostname so that the clients cannot send the SDP offer.

Note that all the echo tests failed. The green ticks are because the job continues on error and writes a failure result.

werift-client-timeout

shinyoshiaki commented 3 years ago

I added some error handling at https://github.com/sipsorcery/webrtc-echoes/commit/4fb816f84c98e8c204c739db48755bf89a005e6f . And also The timeout is set to 30 seconds.

If it happens again, please let me know.

sipsorcery commented 3 years ago

Will do, thanks for the quick fix.