New API

[zeehio]

I have been working on a new API for the package.

The API has several design advantages:

• It integrates better with the Bioconductor ecosystem
• It is designed to provide functions that can be applied to a dataset, a sample or a single spectrum/chromatogram (e.g. smooth)
• Functions applied to datasets are delayed by default, so they are not applied until the data is needed (or the user decided to realize(dataset)). When functions are applied they are processed in parallel.

I have implemented a part of the vignette, including reshape/cutting and smoothing.

I will go for alignment next. We can review de design of the API if you like. Look at the vignette to see if it makes sense to you. I've used generic functions from ProtGenerics (filterRt) and Biobase (smooth) implementing methods for our classes.

ease the work done at the GUI by @AnitaMSLH I have been working on a whole new API

[zeehio]

The vignette: It runs until line 213 where we exit because the rest isn't implemented yet:

https://github.com/sipss/GCIMS/blob/da951672c3ee3e3aa8eeb021d334d0fce96763fd/vignettes/introduction-to-gcims-alternative-api.Rmd#L1-L213

This branch can be installed with:

remotes::install_github("sipss/GCIMS@sergio/new-api", auth_token= "your-personal-access-token")

[zeehio]

Overview as of 508d1531951482d3d339d83bfee3eb9761df9bd9:

• Can run the analysis all in RAM or saving samples in disk.
• Runs the 3 samples vignette (twice?) in roughly 3 minutes

The new API vignette has some differences with respect to the old vignette:

• Cutting samples:

  • New uses rt: [0,1300] s and dt: [1, 17] ms [we easily keep a big region without peaks]
  • Old uses rt: [0,1300] s and dt: [7, 17] ms

• Smoothing:

  • New uses rt: 3s dt: 0.14 ms
  • Old uses rt: 19 points, dt: 19 points

• Decimation:

  • Old uses rt: 2, dt: 2
  • New uses rt: 1, dt: 2

• Time required to build vignette:

  • Old uses 3.6 minutes
  • New uses 3.2 minutes (using a 60% larger drift time axis and twice the number of rt points)

To do things:

• [x] push changes to clustering

Naming issues:

• [x] Decide on as.data.frame vs tidy for GCIMSChromatogram and GCIMSSpectrum?
• [ ] Better name for add_peaklist_rect? Also it needs the dataset, since we want the sample annotations as well to color_by.. or use a peaklist class?
• [x] getGCIMSSample vs getSample vs base::sample name/generic
• [x] getIMS for getting a spectrum? getSpectrum?
• [x] deprecated getEIC for getting a Chromatogram? getChromatogram?

Architecture issues:

• [ ] Should we have an "AlignmentResults" class with plot method?
• [ ] Some we have a "ClusteringResults" class with plot method?
• [ ] getTIS, getRIC might return TIS and RIC classes with plot method?
• [ ] Do we need an MChromatograms MSpectrum class? This simplifies smoothing and baseline plots. getTIS and getRIC for datasets can benefit as well. So yes. And yes so the object has the annotations and can plot based on the annotations as well
• [x] Should we use class-method.R or method-class.R file names?
• [ ] After realize() we should save the dataset object in the folder as well, so we can import the directory

Features we could split and depend on:

• [x] Should sgolayfilt be in an independent package?
• [x] Put sgolayfilt benchmarks on a vignette? [Not worth it]
• [x] Implement geom_*_matrix if possible. Create a package for it?
  • [x] geom_raster_matrix with nativeRaster for overview plots
  • [x] geom_line_matrix to plot multiple geom lines? [Not that easy to do it efficiently in ggplot]

Dependencies / Imports:

• [x] S4Vectors only used for DataFrame. Can we use data.frame instead? [Not worth the exploration]
• [x] Remove lifecycle dependency?
• [x] importFrom rlang abort warn inform

Reading data

• [ ] Helpers for importing CSV files that are not overly specific to a software version
• [ ] Support nos/scm files

Physical units:

• [ ] Peak intensity in volts vs a.u.
• [ ] Support for reduce mobility units. dt_range -> ims_range & ims_unit ?
• [ ] Support for retention index units. rt_range -> gc_range & gc_unit ?
• [ ] find_rip verbosity information prints too many significant digits on drift time limits

Plots

• [ ] plot(dataset) (several samples in subplots, same intensity scale)
• [ ] plot(list of samples) (several samples in subplots, same intensity scale)
• [ ] align should save RIC and TIS before transforming samples, so we can get a before and after plot of them

Vignette and docs:

• [ ] Review vignette plots
• [ ] Review docs from:
  • [ ] as.data.frame vs tidy for GCIMSChromatogram and GCIMSSpectrum
  • [ ] plot for GCIMSChromatogram and GCIMSSpectrum
  • [ ] tidy for GCIMSSample
  • [ ] add_peaklist_rect
  • [ ] create_annotations_table
  • [ ] getIMS, getChromatogram
  • [ ] integratePeaks
  • [ ] peaks
  • [ ] plotRaw vs plot
• [ ] Runnable examples for > 80% of functions of the new API