search

sipwise / rtpengine

The Sipwise media proxy for Kamailio
GNU General Public License v3.0
799 stars 375 forks source link

a=rtcp-rsize and ICE=force #1121

Closed juha-h closed 4 years ago

juha-h commented 4 years ago

Incoming request has SDP media attribute a=rtcp-rsize, but no ICE attributes. I then call rtpengine_offer() with ICE=force key rtpengine adds ICE attributes to SDP, but does not remove a=rtcp-rsize attribute. Microsoft SDP doc https://docs.microsoft.com/en-us/openspecs/office_protocols/ms-sdpext/6cbe6c6c-3ff4-4f45-9fae-f91d1581af8f claims that a=rtcp-rsize should not be included if SDP contains ICE candidate attributes. I'm not sure if that is true, but if so, should rtpengine drop a=rtcp-rsize, when it adds ICE candidates?

rfuchs commented 4 years ago

If true then yes, but I can find no mention of this requirement in either RFC 5506 nor in RFC 8445. I'm not even sure why that requirement would exist, or why usage of one would affect usage of the other. Also the linked article says "SHOULD NOT" and not "MUST NOT" so 🤷

juha-h commented 4 years ago

Yes, sounds like MS bulls**t to me.