sipwise / rtpengine

The Sipwise media proxy for Kamailio
GNU General Public License v3.0
785 stars 368 forks source link

Add option to use pure TCP socket to forward call data (used to reduc… #1777

Closed IgorrG closed 8 months ago

IgorrG commented 9 months ago

…e overal system load on local audio transmition).

IgorrG commented 9 months ago

Name of option 'tls-disable' maybe confusing, it could be good idea to change it to 'tls-disable-handshake' or 'tls-force-tcp'?

rfuchs commented 9 months ago

Name of option 'tls-disable' maybe confusing, it could be good idea to change it to 'tls-disable-handshake' or 'tls-force-tcp'?

Yes, I agree. I'm actually thinking of renaming the tls-... options to tcp-... and then have an option to enable TLS, instead of the other way around.

Backwards compatibility with existing config files would be an issue though. Either retain the tls-... options as an alternative fallback, and/or warn users when they upgrade and don't change the options.