Failure to generate RTCP with requested interval

[szcom]

rtpengine version the issue has been seen with

Version: 11.5.1.11+0~mr11.5.1.11 git-HEAD-51248ea

Used distribution and its version

No response

Linux kernel version used

No response

CPU architecture issue was seen on (see uname -m)

None

Expected behaviour you didn't see

1. Caller (AMR), answer(g711), rtpengine does transcoding. It is asked to "generate RTCP" in NG offer/answer flags.
2. Rtpengine produces RTCP to both sides
3. Caller puts answerer on-hold, "generate RTCP" is in offer/answer flags
4. Rtpengine keeps producing RTCP

I did not see 4 happening, instead Rtpengine stops sending RTCP and caller drops the call

Unexpected behaviour you saw

Rtpengine stops generating RTCP when call is put on-hold, caller says a=sendonly and answerer acks it by a=recvonly "generate RTCP" is also present in offer/answer with sendonly/recvonly

Steps to reproduce the problem

No response

Additional program output to the terminal or logs illustrating the issue

No response

Anything else?

No response

[szcom]

rtcp-interval is in fact doubled, this causes RTCP to arrive with >10s delay by default. In some situations it is too late. the PR https://github.com/sipwise/rtpengine/pull/1783 makes RTCP to tick with the value configured in rtcp-interval

Double counting of the RTCP delay was the reason for solutions mentioned in issue #1644