siqirua / pe

0 stars 0 forks source link

No duplicate detection for a extra white space between words #2

Open siqirua opened 9 months ago

siqirua commented 9 months ago

image.png There is no duplicate detection for inputs like "John Doe" and "John Doe" though they are very likely to be the same person.

soc-se-bot commented 9 months ago

Team's Response

It is an overzealous input validation to trim extra spaces within names. In most phones' contact applications such as the default Phone application by Apple, contacts can be added with more than one space within your contact’s name fields. The contacts will then be treated as different contacts, rather than duplicates.

Take the below example of an Android contact app where "John Doe" with different spaces in between are added. They are then considered as two separate contacts. This shows that leading phone applications allow this, so it's not unusual for our application to do the same.

Screenshot 2023-11-20 at 1.29.29 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

image.png

In CS2103 website, it is clearly said that this can be considered as a feature flaw. Since in reality, 'John Doe' and 'John Doe' are referring the same person, it is good for your app to have this duplication check as well. Android contact app uses the same way does not necessarily mean it is a good practice.