Open siqirua opened 9 months ago
siqirua
commented
9 months ago 
There is no duplication check for the phone number and will not show any message if the newly added person shares a same phone number as any of the existing people. In reality, usually it is not possible for 2 people sharing the same number and this is very likely caused by a typo, which a confirmation message or error message is recommended to be displayed.
nus-pe-script
commented
9 months ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Following similar reasoning, it is very likely in the real world for 2 people to share the same numbers i.e. colleagues in the same department sharing a common office number.
[The team marked this bug as a duplicate of the following bug]
Persons with same email or phone number should not be allowed
I feel that duplicate addresses is alright, as you could have contacts of people from the same family members living in the same house. However, I feel that emails and phone numbers should be unique to a person, and should not be allowed if it is duplicate, or perhaps a warning should be given at least to tell the user that the phone number inputted is a duplicate, in the case of people using the same phone number (eg. children using parent's phone number)
[original: nus-cs2103-AY2324S1/pe-interim#4588] [original labels: severity.Low type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
As our target user is for SoC student event planners, they are expected to contact sponsors or even HR teams of different companies. It is not uncommon for representatives for sponsors/HRs to share a common number/email (i.e., department number/email). As such, it is not accurate to assume that 2 people cannot share the same number or email.
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your reason]
