search

sir-dunxalot / cypress-nextjs-auth0

Cypress commands to support Auth0 and Next.js
60 stars 24 forks source link

feat: refactored .env handling, replaced Travis with GitHub Actions and aligned dependencies w/ nextjs-auth0 #39

Closed natterstefan closed 2 years ago

natterstefan commented 2 years ago

What's new?

Hi @sir-dunxalot, I am about to resolve some of the open issues and as a first step, I updated the dependencies to the latest supported (and required) version. See:

https://github.com/auth0/nextjs-auth0/blob/70f59193b637ba5c5525359282b3c78b555b286b/package.json#L112-L115

This branch also contains a refactoring of the .env handling and replace Travis with GitHub actions (based on my "internal" PR seen here).

Let me know what you think about it, please.

I will continue with my suggestions to help resolve some issues of others and the ones I experienced.

sir-dunxalot commented 2 years ago

Hey @natterstefan. I appreciate the effort here! All sounds good to me.

Personally, I use yarn and that is what I built this project with so yarn is fine :)

Let me know when this is ready for review and merge (or if you have any questions) and we'll get PRs merged in.

natterstefan commented 2 years ago

Hi @sir-dunxalot,

thanks for the quick reply, appreciated it! I must have missed the existing yarn.lock file 😓 . I removed the package-lock.json and updated yarn.lock instead.

This PR is ready for review now.

I have one question related to the suggestions I'll open via PRs soonish. Are you up for replacing Travis with GitHub actions? It's an open-source project which means GitHub Actions are free: https://github.com/pricing

sir-dunxalot commented 2 years ago

@natterstefan I've pulled down this branch. Everything is working (wahoo!) except the test suite fails with 404s for API routes.

image

Are you seeing the same issue? Maybe one of the dep updates requires a code change?

Let me know if you need a cypress.env.json file for local testing and I can send you one via email, Discord, Slack, etc.

natterstefan commented 2 years ago

Interesting 🤔 All tests pass for my created example app for this. Sure let's figure out what's going on together. I'll send you an email now.

natterstefan commented 2 years ago

@sir-dunxalot FYI, I already created a follow-up PR for this one where I refactored the ENV variable handling and moved from Travis to GitHub Actions (because every fork can use GitHub Actions without setting up an additional Travis account then; and personally, I prefer GitHub Actions these days. 😅)

=> https://github.com/natterstefan/cypress-nextjs-auth0/pull/1: as you can see in this PR the CI tests pass. I used the same credentials you sent me.