sirDonovan / Lanette

A bot for Pokemon Showdown written in TypeScript
MIT License
12 stars 28 forks source link

Games: Ignore when guess has a typo in some games #66

Closed Dirain1700 closed 1 year ago

Dirain1700 commented 1 year ago

Approved by Game Corner Staff.

Dirain1700 commented 1 year ago

I want to add function to test filterGuess(), but I have no idea how to make typo on purpose. Do you have an idea?

Dirain1700 commented 1 year ago

Now ignoring typos in: Chimecho's Stat School Natu's Nature Min-Max, Xatu's Nature Clusters, so I convert this to draft (Approved by WarriorGallade)

Dirain1700 commented 1 year ago

fixing it now

sirDonovan commented 1 year ago

No worries, it's not related to your changes

sirDonovan commented 1 year ago

Sorry I only saw the unrelated errors from the master branch before. You might need to have the new test in each individual game it applies to instead of QuestionAndAnswer

Dirain1700 commented 1 year ago

wait, I did not added no changes in toss up, what happens?

sirDonovan commented 1 year ago

Any game that extends the QuestionAndAnswer class will also inherit its unit tests

Dirain1700 commented 1 year ago

ik, so i put the guard, but toss up threw the guard

Dirain1700 commented 1 year ago

I did not realized Hangman and some games have a filterGuess, I fix this right now

sirDonovan commented 1 year ago

Thanks!