Account* plugins: needs code review

[GoogleCodeExporter]

1) Some part of the Account* plugins needs code review.  I think that there are 
possibilities of data lose/db desync in models. This needs to be checked.

2) The code still not include a simple data class to make the code maintainable 
and readable. See issue #165.

3) This code is highly difficult to read because of the multiple qWarnings 
added everywhere in the code. Theses warnings **must** be removed. You can keep 
some of them if you need them for a release debugging (not for your own code 
debugging).

4) We decided to write "code rules" for project with multiple coders/debuggers 
but theses rules are not satisfied in the account* code. 
http://doc.freemedforms.com/coderules.html

5) Code documentation too poor leading to a big waste of time when you try to 
understand/debug the code and are external of the plugin code.

6) Database constants (Table && Fields) must be only accessed by internal code 
of models and database. No where else. So you need to make a correspondance 
between a model enum (data representation of columns) and the table/fields 
inside the internal code of models. There can be difficult bugs to find 
otherwise on any database updates.

All of this is necessary when we work in a community driven project... Untill 
there are only one dev working on account* this is not a in-the-hurry task. But 
if you want help from other devs or if you want to ease the integration of new 
devs, this task is a mandatoryand-high-positive-impact task that should not be 
ignored.

Original issue reported on code.google.com by eric.mae...@gmail.com on 16 Oct 2012 at 10:11

[GoogleCodeExporter]

i'll see that after the stable release.
What is "a simple data class", it is not clear.
But if you want me to work on it at once, ok, but no complain if bugs.

Original comment by pm.desom...@gmail.com on 16 Oct 2012 at 6:49

• Added labels: Priority-Low
• Removed labels: Priority-Critical

[GoogleCodeExporter]

You can manage you work like you want, ask for help or not...
For data class please see

    DrugsDB::IDrug
    Alert::AlertItem
    QModelIndex

for example.

Original comment by berenger...@gmail.com on 16 Oct 2012 at 7:37