search

siralam / BSImagePicker

An image picker that extends BottomSheetDialogFragment. Camera and gallery all in one dialog. Single or Multi Selection.
201 stars 62 forks source link

Can't select image #8

Closed luis-goncalves closed 6 years ago

luis-goncalves commented 6 years ago

Hi When I added BSImagePicker and run and call show from a fragment I get: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/bumptech/glide/Glide; at com.asksira.bsimagepicker.ImageTileAdapter$ImageTileViewHolder.bind(ImageTileAdapter.java:248) at com.asksira.bsimagepicker.ImageTileAdapter.onBindViewHolder(ImageTileAdapter.java:93) at com.asksira.bsimagepicker.ImageTileAdapter.onBindViewHolder(ImageTileAdapter.java:21).

I found out that by adding: implementation 'com.github.bumptech.glide:glide:4.7.1' annotationProcessor 'com.github.bumptech.glide:compiler:4.7.1' to gradle it sort of works but I can't select anything in single mode and in multimode the done button does nothing.

I do get Glide: Failed to find GeneratedAppGlideModule. You should include an annotationProcessor compile dependency on com.github.bumptech.glide:compiler in your application and a @GlideModule annotated AppGlideModule implementation or LibraryGlideModules will be silently ignored

Is there something I miss currently min sdk is 23 Thank you

siralam commented 6 years ago

I expect developers to use Glide v4. Please follow their official documentation to setup. Your error message indicates that you missed your annotation processor dependency.

If you insist to use Glide v3, for now I am not sure how to include older dependency(v3) in your app module but continue to use a more updated dependency(v4) in one of your libraries. You may try to google it for yourself first.

luis-goncalves commented 6 years ago

Did you read: I found out that by adding: implementation 'com.github.bumptech.glide:glide:4.7.1' annotationProcessor 'com.github.bumptech.glide:compiler:4.7.1' that's Glide V4. Also you shouldn't assume that people don't google first. I posted here because nothing was working.

siralam commented 6 years ago

Ah sorry my fault. Will take a look tomorrow.

siralam commented 6 years ago

I cannot reproduce your problem. if nothing happens when selecting an image, I suspect that the callback is not properly implemented. May you post your Fragment's code?

siralam commented 6 years ago

Closed due to no activity.

chebum commented 6 years ago

Hello Sira,

I believe it's wise to add a mention into the readme that we should add 

implementation 'com.github.bumptech.glide:glide:4.7.1'
annotationProcessor 'com.github.bumptech.glide:compiler:4.7.1'

into our gradle build scripts.

siralam commented 6 years ago

@chebum Will do that in the next update. Thanks